Add a method to RpcModule that transforms the module into a RpcModule<()>, i.e. removes the context.
#660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule into a `RpcModule<()>`, i.e. removes the context.
niklasad1
reviewed
Jan 19, 2022
niklasad1
reviewed
Jan 19, 2022
niklasad1
approved these changes
Jan 19, 2022
jsdw
reviewed
Jan 20, 2022
tests/tests/rpc_module.rs
Outdated
Comment on lines
34
to
40
| fn assert_type<T: 'static, Expected: 'static>(_expected: &Expected, explain: Option<&'static str>) { | ||
| use core::any::TypeId; | ||
| match explain { | ||
| None => assert_eq!(TypeId::of::<T>(), TypeId::of::<Expected>()), | ||
| Some(explain) => assert_eq!(TypeId::of::<T>(), TypeId::of::<Expected>(), "{}", explain), | ||
| } | ||
| } |
There was a problem hiding this comment.
Perhaps it's better to move this check to compile-time? ie:
fn assert_type<Expected>(_expected: &Expected) {}Usage (compile error if types don't match):
assert_type::<SomeType>(&some_value);
This becomes quite small and could be inlined into the macro if preferred!
dvdplm
changed the title
decontextualize, that transforms the module into a RpcModule<()>, i.e. removes the context.RpcModule<()>, i.e. removes the context.
jsdw
approved these changes
Jan 21, 2022
maciejhirsz
approved these changes
Jan 21, 2022
Co-authored-by: Maciej Hirsz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #558