[http server]: use similar API for host and origin filtering as WS
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Sep 16, 2021
| }; | ||
| self.allow_hosts = AllowHosts::Only(allow_hosts); | ||
| /// Reset default to allow all hosts. | ||
| pub fn allow_all_hosts(mut self) -> Self { |
There was a problem hiding this comment.
probably not needed but added it because the WS server has it
Co-authored-by: David <[email protected]>
niklasad1
changed the title
WS
maciejhirsz
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example usage here
The code or API is similar to what we have in WS server but I prefer to do an attempt to merge them in another PR.
Mostly the differences is how we get back the headers in soketto vs hyper I think.