Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to treat empty JSON response as no params #446

Merged
merged 23 commits into from
Sep 1, 2021
Merged

Make it possible to treat empty JSON response as no params #446

merged 23 commits into from
Sep 1, 2021

Conversation

niklasad1
Copy link
Member

Closing #441

niklasad1
niklasad1 commented Aug 27, 2021
View reviewed changes
types/src/v2/params.rs Outdated Show resolved Hide resolved
dvdplm
dvdplm reviewed Aug 29, 2021
View reviewed changes
types/src/v2/params.rs Outdated Show resolved Hide resolved
types/src/v2/params.rs Outdated Show resolved Hide resolved
types/src/v2/params.rs Outdated Show resolved Hide resolved
types/src/v2/params.rs Outdated Show resolved Hide resolved
types/src/v2/params.rs Show resolved Hide resolved
types/src/v2/params.rs Outdated Show resolved Hide resolved
dvdplm
dvdplm reviewed Aug 29, 2021
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some docs here I think, and maybe less long names?

niklasad1
niklasad1 commented Aug 30, 2021
View reviewed changes
types/src/v2/params.rs Outdated Show resolved Hide resolved
niklasad1
niklasad1 commented Aug 30, 2021
View reviewed changes
types/src/v2/params.rs Outdated Show resolved Hide resolved
maciejhirsz
maciejhirsz approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggestion for the trims :)

maciejhirsz
maciejhirsz reviewed Aug 31, 2021
View reviewed changes
types/src/v2/params.rs Outdated Show resolved Hide resolved
@niklasad1
Copy link
Member Author

@dvdplm @maciejhirsz can you have another look at this now?

I confused myself with a faulty test but I moved the [] -> "" to RpcParamsSequence such that RpcParams still works for [] and {} should be ready to go

@niklasad1 niklasad1 requested a review from jsdw September 1, 2021 12:05
jsdw
jsdw reviewed Sep 1, 2021
View reviewed changes
proc-macros/src/helpers.rs Outdated Show resolved Hide resolved
dvdplm
dvdplm approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jsdw
jsdw approved these changes Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; a couple of comments but nothing important :)

@niklasad1 niklasad1 mentioned this pull request Sep 1, 2021
Closed
@niklasad1 niklasad1 merged commit bf211cb into master Sep 1, 2021
@niklasad1 niklasad1 deleted the na-fix-441 branch September 1, 2021 15:37
@niklasad1 niklasad1 mentioned this pull request Sep 3, 2021
Closed
thepacketgeek added a commit to thepacketgeek/bgpd-rs that referenced this pull request Oct 14, 2021
@thepacketgeek
Updating to jsonrpsee 0.4.1
ed83b5b 
Updating to pick-up a [fix](paritytech/jsonrpsee#446) for empty JSON req as no params so that `bgpd show routes advertised` (and `learned`) works without specifying a peer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejhirsz maciejhirsz maciejhirsz approved these changes

@jsdw jsdw jsdw approved these changes

@dvdplm dvdplm dvdplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niklasad1 @dvdplm @maciejhirsz @jsdw