fix(client): support notifications with no params #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jomik
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
This looks great.
Use case for me is listening to state on my 3d printer.
https://moonraker.readthedocs.io/en/latest/web_api/#klippy-disconnected
It could have been implemented as a single method with a state enum, but they chose to implement multiple notifications, one for each state.
|
Aight, I see thanks for the explanation |
lexnv
approved these changes
Aug 1, 2024
niklasad1
changed the title
niklasad1
changed the title
jsdw
approved these changes
Aug 1, 2024
|
Do you have an estimate of when you will create a release with this fix? It is currently interferring with my progress 😅 |
|
I'll release it today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1435
Technically notifications can omit the params field according to JSON-RPC spec which this fixes.
However, it's quite weird to emit notifications without data in them in such scenarios we just push
nullto the notification handler.In contrary, subscriptions requires params field where the subscription ID is sent in every message and that's why I didn't change the notification type i.e, just a type alias
Notification<'a, Option<serde_json::Value>>