Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proc-macros): some types are missing when using proc-macros but only the server-core feature is enabled #1359

Closed

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Apr 28, 2024

Cargo.toml:

jsonrpsee = { version = "0.22.4", features = ["client-core", "server-core", "macros"] }

Error:

error[E0433]: failed to resolve: could not find `RpcModule` in `jsonrpsee`
  --> client/rpc/api/src/debug.rs:25:1
   |
25 | #[rpc(client, server, namespace = "debug")]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `RpcModule` in `jsonrpsee`
   |
   = note: this error originates in the attribute macro `rpc` (in Nightly builds, run with -Z macro-backtrace for more info)
error[E0433]: failed to resolve: could not find `ResponsePayload` in `jsonrpsee`
  --> client/rpc/api/src/debug.rs:25:1
   |
25 | #[rpc(client, server, namespace = "debug")]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find `ResponsePayload` in `jsonrpsee`

@koushiro koushiro requested a review from a team as a code owner April 28, 2024 11:33
@koushiro koushiro changed the title fix(proc-macros): some types are missing when using proc-macors but only the server-core feature is enabled fix(proc-macros): some types are missing when using proc-macors but only the server-core feature is enabled Apr 28, 2024
@koushiro koushiro changed the title fix(proc-macros): some types are missing when using proc-macors but only the server-core feature is enabled fix(proc-macros): some types are missing when using proc-macros but only the server-core feature is enabled Apr 28, 2024
@koushiro
Copy link
Contributor Author

@niklasad1 PTAL

@niklasad1 niklasad1 closed this Apr 29, 2024
@koushiro koushiro deleted the fix-server-core-feature branch April 29, 2024 08:27
@koushiro koushiro restored the fix-server-core-feature branch April 29, 2024 08:47
@koushiro koushiro deleted the fix-server-core-feature branch April 29, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants