client: support batched subscription notifs #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
reviewed
Mar 26, 2024
| { | ||
| let mut nh: Subscription<String> = | ||
| client.subscribe("sub", rpc_params![], "unsub").with_default_timeout().await.unwrap().unwrap(); | ||
| let response: String = nh.next().with_default_timeout().await.unwrap().unwrap().unwrap(); |
There was a problem hiding this comment.
nit: It would be interesting to extend this for 2 subscriptions and 2 (or more) batched notifications and ensure that responses to go appropriate handlers:
let server = WebSocketTestServer::with_hardcoded_subscription(
"127.0.0.1:0".parse().unwrap(),
server_subscription_id_response(Id::Num(0)),
server_batched_subscription(&[("sub1", "batched_notif1"), ("sub2", "resp2")]),
)
let mut sub1 = client.subscribe("sub1", rpc_params![], "unsub");
let mut sub2 = client.subscribe("sub2", rpc_params![], "unsub");
assert_eq!(sub1.next(), "batched_notif1");
assert_eq!(sub2.next(), "resp2");
There was a problem hiding this comment.
This would be a nice extra check yup; right now we can see that the subscription response comes back ok but would be nice to know that eg a few batched subscription responses all end up in the right place :)
There was a problem hiding this comment.
If you have a look at the updated test we now emit [notif1, notif2, sub] and check that it goes to the correct handler (notif=sub, sub_notif=sub)
Sure we could spawn a few more subscriptions to ensure the responses are propagated properly in the Vec
niklasad1
added a commit
that referenced
this pull request
Apr 8, 2024
* client: support batched subscriptions notifs * address grumbles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #1327