fix(server): host filter via URI read authority #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that the HOST is sent via the URI and when that is the case the server should read the `Authority (host:port)` not only the host
niklasad1
commented
Aug 10, 2023
| /// such that we must check both. | ||
| pub(crate) fn fetch_authority(request: &hyper::Request<hyper::Body>) -> Option<&str> { | ||
| let host_header = http_helpers::read_header_value(request.headers(), hyper::header::HOST); | ||
| let uri = request.uri().authority(); |
There was a problem hiding this comment.
This is fix and mainly regards HTTP2 but could be some other edge-case as well.
Thus, if one would enable a filter for port X and the request is targets port X but it's not read and would regarded as the default port if just the host is read i.e, not the port
jsdw
approved these changes
Aug 10, 2023
lexnv
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the HOST is sent via the URI and when that is the case the server should read the
Authority (host:port)not only the host