New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split client and server errors #1122

Merged

niklasad1 merged 24 commits into master from na-split-error-types

Dec 6, 2023

Member

niklasad1 commented May 15, 2023 •

edited

Loading

Close #1088


          split client and server error

4c293a4

niklasad1 added the breaking change label

niklasad1 added 6 commits

December 1, 2023 17:35


          Merge remote-tracking branch 'origin/master' into na-split-error-types

c09bd57


          cargo fmt

5524eba


          remove old code

4562b21


          fix tests

2181ed0


          cargo fmt

46fdece


          fix rustdoc links

2bf937a

niklasad1 changed the title ~~WIP: split client and server errors~~ refactor: split client and server errors

niklasad1 marked this pull request as ready for review

December 4, 2023 09:57

niklasad1 requested a review from a team as a code owner

December 4, 2023 09:57


          make clippy happy

7c6f9e3

niklasad1 commented

View reviewed changes

server/src/future.rs Outdated Show resolved Hide resolved


          Update server/src/future.rs

niklasad1 commented

View reviewed changes

client/http-client/src/client.rs Outdated Show resolved Hide resolved


          Update client/http-client/src/client.rs

e238351

niklasad1 commented

View reviewed changes

client/http-client/src/client.rs Outdated Show resolved Hide resolved


          Update client/http-client/src/client.rs

niklasad1 commented

View reviewed changes

core/src/client/async_client/helpers.rs Outdated Show resolved Hide resolved


          Update core/src/client/async_client/helpers.rs

niklasad1 commented

View reviewed changes

core/src/client/async_client/helpers.rs Outdated Show resolved Hide resolved


          Update core/src/client/async_client/helpers.rs

5de5c0a

niklasad1 commented

View reviewed changes

core/src/client/async_client/mod.rs Outdated Show resolved Hide resolved


          Update core/src/client/async_client/mod.rs

cc85b30

niklasad1 commented

View reviewed changes

core/src/client/async_client/mod.rs Outdated Show resolved Hide resolved

niklasad1 added 4 commits

December 4, 2023 11:24


          Update core/src/client/async_client/mod.rs

570be49


          fix more todos

6f99955


          unused dep: soketto

bebaa3b


          remove unused error variant

e013884

niklasad1 mentioned this pull request

[tracking]: Release v0.21 #1241

Closed

8 tasks

lexnv reviewed

View reviewed changes

client/ws-client/src/lib.rs Show resolved Hide resolved

lexnv approved these changes

View reviewed changes

Contributor

lexnv left a comment

LGTM!


          Merge remote-tracking branch 'origin/master' into na-split-error-types

ec1231c

niklasad1 commented

View reviewed changes

core/src/lib.rs Outdated Show resolved Hide resolved

niklasad1 added 2 commits

December 5, 2023 13:28


          Update core/src/lib.rs

a16ee71


          cargo fmt

86b29a9

Collaborator

jsdw commented Dec 5, 2023

Looks good to me too! Only tiny thing I wondered was whether to have a client/error.rs file to be consistent with server/error.rs but I don't think it matters :)

jsdw approved these changes

View reviewed changes

niklasad1 added 2 commits

December 6, 2023 09:45


          fix grumbles: move client error to own mod

71ca1dc


          simplify imports

dd75d00

niklasad1 commented

View reviewed changes

core/src/client/error.rs Outdated Show resolved Hide resolved


          Update core/src/client/error.rs

b628df6

niklasad1 merged commit 0ca84f9 into master

11 checks passed

niklasad1 deleted the na-split-error-types branch

December 6, 2023 09:20

carver added a commit to carver/glados that referenced this pull request


          fix: use new Error import in upgraded jsonrpsee

04608f1

Errors were split into client & server types here:
paritytech/jsonrpsee#1122

carver added a commit to carver/glados that referenced this pull request


          fix: use new Error import in upgraded jsonrpsee

76fdac9

Errors were split into client & server types here:
paritytech/jsonrpsee#1122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change