Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use integer, not string for block index in chainHead_follow events #84

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Use integer, not string for block index in chainHead_follow events #84

merged 1 commit into from
Sep 12, 2023

Conversation

jsdw
Copy link
Collaborator

@jsdw jsdw commented Aug 29, 2023 •
edited
Loading

Closes #83

/cc @tomaka @josepot @lexnv

@jsdw jsdw requested a review from josepot September 1, 2023 09:00
josepot
josepot approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@josepot josepot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I already mentioned before: this change makes sense to me. However, I would like to make sure that @tomaka is also on board with this.

tomaka
tomaka approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, the API should be consistent. The archive API also uses hexadecimal strings to represent block heights. However, given that the maximum "safe" number in JavaScript is 2^53 – 1, it's safe to adjust the archive API as well.

@tomaka tomaka mentioned this pull request Sep 4, 2023
Merged
@lexnv lexnv mentioned this pull request Sep 12, 2023
Closed
@jsdw
Copy link
Collaborator Author

jsdw commented Sep 12, 2023 •
edited
Loading

I'll merge this since @lexnv's PR #90 changes block heighs to integers

@jsdw jsdw merged commit b521e1e into main Sep 12, 2023
@lexnv lexnv mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@josepot josepot josepot approved these changes

@tomaka tomaka tomaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transaction_submitAndWatch: consider returning "index" as integer, not string
4 participants
@jsdw @tomaka @josepot @lexnv