Stabilize chainHead to version 1
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
jsdw
previously approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Looks good to me! We've been using these methods for a while in Subxt and they are roughly at parity with the legacy methods in terms of the functionality exposed.
My stance is that, although there are likely a few changes I'd like to see here, it's much better to stabilise something now rather than get caught up with aiming for perfection and not get anything stabilised for a while.
Once these are stabilised, we can introduce v2 etc methods if needed to accomodate future requests and changes. We can also have confidence that PAPI will Just Work, and work to stabilise the "unstable backend" in Subxt (which relies on these currently unstable methods).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stabilizes all chainHead methods to version 1.
cc @paritytech/subxt-team @tomaka @josepot