chainHead/unpin: Return error on duplicate hashes #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
tomaka
approved these changes
Feb 14, 2024
niklasad1
approved these changes
Feb 14, 2024
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Feb 14, 2024
This PR addresses an issue where calling chainHead_unpin with duplicate hashes could lead to unintended side effects. This backports: paritytech/json-rpc-interface-spec#135 While at it, have added a test to check that the global reference count is decremented only once on unpin. cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Davide Galassi <[email protected]>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
This PR addresses an issue where calling chainHead_unpin with duplicate hashes could lead to unintended side effects. This backports: paritytech/json-rpc-interface-spec#135 While at it, have added a test to check that the global reference count is decremented only once on unpin. cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Davide Galassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the behavior of the server when the
chainHead_unpinreceives duplicate hashes.When duplicate hashes are received as parameters, the server returns
-32804.Likewise, the server could return the
-32602for invalid parameters. However, I thought a dedicated error would provide clear details to the user wrt what needs to be changed. This felt appropriate since we also have a dedicated error forwithRuntimeflag:cc @paritytech/subxt-team
cc: paritytech/polkadot-sdk#3313 (comment)
Closes: #133