fix: rpc_methods return value
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
reviewed
Feb 2, 2024
tomaka
reviewed
Feb 5, 2024
Co-authored-by: Pierre Krieger <[email protected]>
tomaka
approved these changes
Feb 5, 2024
lexnv
approved these changes
Feb 5, 2024
|
Friendly reminder that I can no longer merge this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference: smol-dot/smoldot#1657
Basically what happened was that I implemented things on my end according to the spec, and things blowed up because smoldot was returning an object, rather than returning an Array (as per the spec definition). So, I opened a PR on smoldot to "fix the issue". However, it turns out that what's wrong is the spec, because this return value should stay compliant with the "legacy" API.