Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Added Asset Conversion in Kusama #2935

Merged
merged 21 commits into from
Aug 19, 2023
Merged

Added Asset Conversion in Kusama #2935

merged 21 commits into from
Aug 19, 2023

Conversation

PatricioNapoli
Copy link
Contributor

@PatricioNapoli PatricioNapoli commented Jul 25, 2023 •
edited by joepetrowski
Loading

Solves paritytech/polkadot#2882 by porting Westend asset conversion addition to Kusama.

Pending:

  • Generate the pallet_asset_conversion and pallet_assets_pools weights
  • Check the emulated integration tests (KSM is probably a bit different)

@PatricioNapoli PatricioNapoli force-pushed the pato/asset-conversion-ksm branch from e8245f2 to 1a26aa9 Compare July 26, 2023 20:32
@PatricioNapoli
Copy link
Contributor Author

bot clean
bot bench cumulus-assets --runtime asset-hub-kusama --pallet=pallet_asset_conversion

@PatricioNapoli PatricioNapoli force-pushed the pato/asset-conversion-ksm branch from d008d1f to 538b520 Compare July 26, 2023 22:09
@PatricioNapoli
Copy link
Contributor Author

bot clean
bot bench cumulus-assets --runtime asset-hub-kusama --pallet=pallet_assets

@command-bot
Copy link

command-bot bot commented Jul 27, 2023 •
edited
Loading

@PatricioNapoli https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3276873 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 29-0b967143-84fd-4561-8426-a589547a6751 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jul 27, 2023

@PatricioNapoli Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=asset-hub-kusama --runtime_dir=assets --target_dir=cumulus --pallet=pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3276873 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3276873/artifacts/download.

@PatricioNapoli PatricioNapoli force-pushed the pato/asset-conversion-ksm branch from ad10afc to 33166eb Compare July 28, 2023 16:34
@PatricioNapoli PatricioNapoli force-pushed the pato/asset-conversion-ksm branch from 33166eb to 5e24393 Compare July 28, 2023 21:28
@PatricioNapoli PatricioNapoli added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C5-high PR touches the given topic and has a high impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jul 28, 2023
@PatricioNapoli PatricioNapoli marked this pull request as ready for review July 28, 2023 21:30
@paritytech-ci paritytech-ci requested review from a team July 28, 2023 21:30
@PatricioNapoli PatricioNapoli added the T1-runtime This PR/Issue is related to the topic “runtime”. label Jul 28, 2023
joepetrowski
joepetrowski reviewed Aug 1, 2023
View reviewed changes
parachains/integration-tests/emulated/assets/asset-hub-kusama/src/tests/swap.rs Outdated Show resolved Hide resolved
parachains/integration-tests/emulated/assets/asset-hub-kusama/src/tests/swap.rs Outdated
Comment on lines 284 to 293
assert_ok!(
<AssetHubKusama as AssetHubKusamaPallet>::AssetConversion::swap_exact_tokens_for_tokens(
<AssetHubKusama as Parachain>::RuntimeOrigin::signed(AssetHubKusamaSender::get()),
path,
100000,
1000,
AssetHubKusamaSender::get().into(),
true
)
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK here but perhaps a separate test (swap_via_remote_program) that will use this call within Transact, but shows a foreign chain's XCM program to execute a swap.

parachains/runtimes/assets/asset-hub-kusama/src/lib.rs Outdated Show resolved Hide resolved
parachains/runtimes/assets/asset-hub-kusama/src/lib.rs Outdated Show resolved Hide resolved
parachains/runtimes/assets/asset-hub-westend/src/xcm_config.rs Outdated Show resolved Hide resolved
parachains/runtimes/assets/asset-hub-kusama/src/xcm_config.rs Outdated Show resolved Hide resolved
parachains/runtimes/assets/asset-hub-kusama/src/xcm_config.rs Outdated Show resolved Hide resolved
parachains/runtimes/assets/asset-hub-kusama/src/lib.rs Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team August 1, 2023 08:11
@paritytech-ci paritytech-ci requested a review from a team August 16, 2023 14:32
gilescope and others added 5 commits August 17, 2023 08:59
@gilescope
storage to const
02871e9 
We're not planning on setting this via an on chain vote so let's have it as a const.
@joepetrowski
unneeded tests
0e8cad1
@joepetrowski
const
41ecbb9
@joepetrowski
shorter line
479aa8e
@joepetrowski
missed one
08abab8
@gilescope gilescope requested a review from jsidorenko August 18, 2023 10:28
@joepetrowski joepetrowski mentioned this pull request Aug 18, 2023
Closed
@joepetrowski
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 464ab8b into master Aug 19, 2023
@paritytech-processbot paritytech-processbot bot deleted the pato/asset-conversion-ksm branch August 19, 2023 14:24
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joepetrowski joepetrowski joepetrowski approved these changes

@xlc xlc xlc left review comments

@bkchr bkchr bkchr approved these changes

@gilescope gilescope gilescope approved these changes

@jsidorenko jsidorenko Awaiting requested review from jsidorenko

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C5-high PR touches the given topic and has a high impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PatricioNapoli @joepetrowski @gilescope @xlc @bkchr