Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make System Parachains trusted Teleporters #2842

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Make System Parachains trusted Teleporters #2842

wants to merge 17 commits into from

Conversation

NachoPal
Copy link
Contributor

@NachoPal NachoPal commented Jul 7, 2023

Make System Parachain trusted Teleporters of each other.

System Parachains should be able to teleport their native asset between them.

@NachoPal
Copy link
Contributor Author

NachoPal commented Jul 7, 2023

bot fmt

@command-bot
Copy link

command-bot bot commented Jul 7, 2023 •
edited
Loading

@NachoPal https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3149633 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-69d2998d-85f7-4c33-9ecc-11a287bf2a33 to cancel this command or bot cancel to cancel all commands in this pull request.

@NachoPal NachoPal added A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes labels Jul 7, 2023
@paritytech-ci paritytech-ci requested review from a team July 7, 2023 19:23
@NachoPal NachoPal added the C3-medium PR touches the given topic and has a medium impact on builders. label Jul 7, 2023
@command-bot
Copy link

command-bot bot commented Jul 7, 2023

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3149633 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3149633/artifacts/download.

@NachoPal NachoPal added the T7-system_parachains This PR/Issue is related to System Parachains. label Jul 7, 2023
@NachoPal NachoPal requested review from joepetrowski and bkontur and removed request for a team July 7, 2023 19:24
@paritytech-ci paritytech-ci requested review from a team July 7, 2023 19:25
@NachoPal NachoPal requested review from gilescope and removed request for a team July 7, 2023 19:25
@paritytech-ci paritytech-ci requested review from a team July 7, 2023 19:25
@NachoPal NachoPal added T1-runtime This PR/Issue is related to the topic “runtime”. and removed T7-system_parachains This PR/Issue is related to System Parachains. labels Jul 7, 2023
joepetrowski
joepetrowski reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@joepetrowski joepetrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. A few questions. Given the sensitivity of Teleporter, would definitely like some review from @KiChjang

parachains/common/src/xcm_config.rs Outdated Show resolved Hide resolved
parachains/runtimes/assets/asset-hub-kusama/src/xcm_config.rs Outdated Show resolved Hide resolved
parachains/runtimes/assets/asset-hub-kusama/src/xcm_config.rs Show resolved Hide resolved
parachains/runtimes/assets/common/Cargo.toml Outdated Show resolved Hide resolved
parachains/integration-tests/emulated/assets/asset-hub-kusama/src/lib.rs Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team July 10, 2023 15:11
@command-bot
Copy link

command-bot bot commented Jul 12, 2023

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3171599 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3171599/artifacts/download.

@NachoPal NachoPal requested review from KiChjang and removed request for KiChjang July 18, 2023 08:15
@NachoPal
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Aug 11, 2023 •
edited
Loading

@NachoPal https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3368180 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 25-1976e01e-e0b8-4619-ad37-9f12bb957e49 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Aug 11, 2023

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3368180 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3368180/artifacts/download.

KiChjang
KiChjang reviewed Aug 11, 2023
View reviewed changes
parachains/runtimes/assets/asset-hub-kusama/src/xcm_config.rs
/// - teleportation of sibling parachain's assets (as ForeignCreators).
pub type TrustedTeleporters = (
NativeAsset,
IsForeignConcreteAsset<FromSiblingParachain<parachain_info::Pallet<Runtime>>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit silly, couldn't we just have IsSiblingParachainAsset and call it a day? The code for IsForeignConcreteAsset mostly delegates to the IsForeign type parameter anyway.

@joepetrowski joepetrowski mentioned this pull request Aug 14, 2023
Merged
@joepetrowski
Copy link
Contributor

bot rebase

@paritytech-processbot
Copy link

Rebased

@joepetrowski joepetrowski mentioned this pull request Aug 24, 2023
Open
@NachoPal NachoPal mentioned this pull request Sep 2, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joepetrowski joepetrowski joepetrowski approved these changes

@bkontur bkontur bkontur approved these changes

@KiChjang KiChjang KiChjang approved these changes

@gilescope gilescope Awaiting requested review from gilescope

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C3-medium PR touches the given topic and has a medium impact on builders. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NachoPal @joepetrowski @KiChjang @bkontur