Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Runtime: Root can promote on Polkadot Collectives #2781

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Runtime: Root can promote on Polkadot Collectives #2781

merged 2 commits into from
Jun 25, 2023

Conversation

gavofyork
Copy link
Member

@gavofyork gavofyork commented Jun 25, 2023 •
edited
Loading

Closes #2777

Ranked Collective assumes that PromoteOrigin can provide a successful origin.

@gavofyork gavofyork added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. T1-runtime This PR/Issue is related to the topic “runtime”. labels Jun 25, 2023
@gavofyork gavofyork requested review from muharem and bkontur June 25, 2023 12:03
@gavofyork gavofyork merged commit c492bd7 into master Jun 25, 2023
@gavofyork gavofyork deleted the gav-fix-benchmarks branch June 25, 2023 19:48
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
@JesseAbram JesseAbram mentioned this pull request Oct 26, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@muharem muharem muharem approved these changes

@gilescope gilescope gilescope approved these changes

@bkontur bkontur Awaiting requested review from bkontur

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collectives-polkadot pallet_ranked_collective::remove_member benchmark fails
3 participants
@gavofyork @gilescope @muharem