This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 380
Move ExportGenesisStateCommand
and ExportGenesisWasmCommand
to cumulus-client-cli
#1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-client-cli Signed-off-by: koushiro <[email protected]>
Signed-off-by: koushiro <[email protected]>
@bkchr @shawntabrizi PTAL |
Signed-off-by: koushiro <[email protected]>
@KiChjang could you take a look this PR? |
Looks fine. What does it solve? |
shawntabrizi
added
B0-silent
Changes should not be mentioned in any release notes
Q0-trivial
labels
Jun 14, 2022
If downstream users want to add these two commands, they don't need to implement them by themselves any more. |
shawntabrizi
approved these changes
Jun 14, 2022
@bkchr could you take a look this PR? I wanna it could be included in the next polkadot release. |
bkchr
approved these changes
Jun 17, 2022
/tip small |
A small tip was successfully submitted for koushiro (15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK on polkadot). https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/treasury/tips |
Sorry for the delay. Merge master then I'm going to merge this. |
@bkchr Done |
Ty |
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Jul 6, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Jul 9, 2022
6 tasks
5 tasks
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: koushiro [email protected]
polkadot address: 15XuanNimo5951s3RjFTPX1AvYVnCwfr3SDhb3AV4fQF3LpK