New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for server side rendering #2

Merged

paramsinghvc merged 1 commit into paramsinghvc:master from jantimon:patch-1

Oct 8, 2020

Contributor

jantimon commented Mar 23, 2020 •

edited

Loading

Hey :)

If I am using any <Anime> component the entire server side rendering explodes with the following error:

@mollycule/react-anime/dist/index.js?:3
  }(window, (function(e, t, r) {
    ^
  ReferenceError: window is not defined

this pull request uses the global this instead to get around that issue as recommend here:

https://webpack.js.org/configuration/output/#outputglobalobject

I also renamed the library from useRedux to reactAnimeJs 😉


          feat: Add support for server side rendering

f4ca190

paramsinghvc merged commit 2e439c7 into paramsinghvc:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet