Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add context2d setLineDash() and lineDashOffset. #3169

Merged
merged 2 commits into from
May 28, 2021
Merged

add context2d setLineDash() and lineDashOffset. #3169

merged 2 commits into from
May 28, 2021

Conversation

flyskyko
Copy link
Contributor

I added setLineDahs() and lineDashOffset to context2d.
When I ran the local test, the two tests below failed, but the base master branch also failed, so I register this PR.

    ✖ html loads html2canvas asynchronously
      Chrome 90.0.4430.212 (Mac OS 10.15.7)
    ✖ renders font-faces
      Chrome 90.0.4430.212 (Mac OS 10.15.7)

@flyskyko
Copy link
Contributor Author

flyskyko commented May 21, 2021 •
edited
Loading

Only IE11 failed. I have no idea what to do.
https://travis-ci.org/github/MrRio/jsPDF/builds/771883208#L5100

@flyskyko flyskyko force-pushed the context2d-setlinedash branch from 2b4b6e8 to 61eb7cc Compare May 21, 2021 13:16
@flyskyko flyskyko force-pushed the context2d-setlinedash branch from 61eb7cc to 376a3ae Compare May 21, 2021 13:19
@flyskyko
Copy link
Contributor Author

Fixed CI tests.

HackbrettXXX
HackbrettXXX requested changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :) Looks good so far. But I think we should add the getLineDash method, as well.

src/modules/context2d.js Show resolved Hide resolved
@flyskyko
Copy link
Contributor Author

Added getLineDash(). However, the CI test failed. There seems to be a problem with saucelabs.

@flyskyko flyskyko requested a review from HackbrettXXX May 25, 2021 13:21
HackbrettXXX
HackbrettXXX approved these changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks! I've restarted the job.

@HackbrettXXX
Copy link
Collaborator

Mmh doesn't seem to help. Looks like https://saucelabs.com/downloads/sc-4.6.5-linux32.tar.gz has been removed? Maybe we need to update karma-sauce-launcher or the saucelabs browser versions? I'm gonna run the job tomorrow again, maybe this is just a temporary issue.

@HackbrettXXX
Copy link
Collaborator

saucelabs/node-saucelabs#116

@HackbrettXXX HackbrettXXX merged commit cef97fb into parallax:master May 28, 2021
@flyskyko
Copy link
Contributor Author

Thank you. 😄

@HackbrettXXX HackbrettXXX mentioned this pull request Jul 13, 2021
Closed
@HackbrettXXX HackbrettXXX mentioned this pull request Jul 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flyskyko @HackbrettXXX