Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use PrimitiveSignature instead of Signature #13087

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat: Use PrimitiveSignature instead of Signature #13087

merged 1 commit into from
Dec 3, 2024

Conversation

moricho
Copy link
Contributor

@moricho moricho commented Dec 3, 2024 •
edited
Loading

PrimitiveSignature was introduced in alloy-rs/core#776 and Signature will be deprecated. We should use PrimitiveSignature instead.
(maybe this is the last part where the old Signature is still being used in reth)

from: alloy-rs/core#788

@mattsse mattsse added this pull request to the merge queue Dec 3, 2024
@mattsse mattsse added the C-enhancement New feature or request label Dec 3, 2024
Merged via the queue into paradigmxyz:main with commit 74017ba Dec 3, 2024
42 checks passed
@moricho moricho deleted the use-primitive-signature branch December 14, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moricho @mattsse