Upgrade to Rundeck 4.17.6 #8
Conversation
There was a problem hiding this comment.
Rundeck does not support JDK17. Only Java 11 is supported. Ref: https://docs.rundeck.com/docs/administration/install/system-requirements.html
Dockerfile
Outdated
| # Install k8s-sidecar | ||
| RUN set -x \ | ||
| && apt-get update \ | ||
| && apt-get -y install git python3.11-venv python3 python3-pip gcc \ | ||
| && cd /tmp \ | ||
| && git clone https://github.com/kiwigrid/k8s-sidecar.git \ | ||
| && cd k8s-sidecar \ | ||
| # merged fixes | ||
| && git checkout 392b8392c4511b0ae6f8d52beb1eda77a07ec970 \ | ||
| && cd src \ | ||
| && pip install -r requirements.txt \ | ||
| && python3 -m venv .venv && .venv/bin/pip install --no-cache-dir -U pip setuptools \ | ||
| && .venv/bin/pip install --no-cache-dir -r requirements.txt \ | ||
| && rm requirements.txt \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && cp -a /tmp/k8s-sidecar/src/ /sidecar \ | ||
| && rm -rf /tmp/k8s-sidecar \ | ||
| ; |
There was a problem hiding this comment.
Please pin this install to a specific release. eg git checkout 1.25.3
install-openjdk-11.sh
Outdated
|
|
||
| export DEBIAN_FRONTEND=noninteractive | ||
|
|
||
| echo "deb http://deb.debian.org/debian bullseye main" > /etc/apt/sources.list.d/openjdk-11.list |
There was a problem hiding this comment.
What is this script doing? Are we just installing the debian 11 (bullseye) packing on debian 12 (bookworm)? This is probably not safe.
There was a problem hiding this comment.
diff --git a/Dockerfile b/Dockerfile
index d0600dd..793c60f 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -12,10 +12,14 @@ RUN set -x \
;
# Install JDK11
-COPY install-openjdk-11.sh /
RUN set -x \
&& mkdir /etc/ssl/certs/java/ \
- && /install-openjdk-11.sh \
+ && wget -O - https://packages.adoptium.net/artifactory/api/gpg/key/public | apt-key add - \
+ && echo "deb https://packages.adoptium.net/artifactory/deb $(awk -F= '/^VERSION_CODENAME/{print$2}' /etc/os-release) main" | tee /etc/apt/sources.list.d/adoptium.list \
+ && apt-get update \
+ && apt-get install --no-install-recommends --no-install-suggests -y temurin-11-jdk \
+ && apt-get clean \
+ && rm -rf /var/lib/apt/lists/* \
;
# Install Google Cloud SDK@macropin what do you think about using adoptium instead? I'll push this to the branch/PR if you agree.
https://adoptium.net/blog/2021/12/eclipse-temurin-linux-installers-available/
| install_helm 3.9.4 | ||
| install_helm 3.10.3 | ||
| install_helm 3.11.2 | ||
| install_helm 3.12.3 | ||
|
|
There was a problem hiding this comment.
Add Helm 3.13.x (what ever the latest 3.13 is)
install-tools.sh
Outdated
|
|
||
| install_helm 3.6.3 | ||
| install_helm 3.7.2 | ||
| install_helm 3.8.2 | ||
| install_helm 3.9.4 | ||
| install_helm 3.10.3 | ||
| install_helm 3.11.2 |
install-tools.sh
Outdated
|
|
||
| install_kubectl 1.21.3 | ||
| install_kubectl 1.22.4 | ||
| install_kubectl 1.23.17 | ||
| install_kubectl 1.24.12 | ||
| install_kubectl 1.25.8 | ||
| install_kubectl 1.26.3 |
There was a problem hiding this comment.
Upgrade to the latest 1.24.x, 1.25.x and 1.26.x releases
Add 1.27 and 1.28 latest releases
|
Please update this PR. We want to:
|
macropin
changed the title
macropin
changed the title
Dockerfile
Outdated
| && cp -a /tmp/k8s-sidecar/src/ /sidecar \ | ||
| && rm -rf /tmp/k8s-sidecar \ | ||
| ; | ||
|
|
||
Thank you, Andrew. |
Andrew's PR for bug fix had been merged by the code owner.