-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fixed warning about convert_objects in doc build #26679
Conversation
Thanks for the PR! What warning were you getting? Any easy way to detect others? |
Codecov Report
@@ Coverage Diff @@
## master #26679 +/- ##
===========================================
+ Coverage 41.84% 90.4% +48.56%
===========================================
Files 174 174
Lines 50663 50663
===========================================
+ Hits 21201 45803 +24602
+ Misses 29462 4860 -24602
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nadebu I see that one file (doc/esample.feather
was added by mistake). Can you please remove it?
Also, I think your change is probably fixing one of the errors, but a similar error is happening in the example immediately after in the PR. Can you apply the same change there please?
Thanks!
@@ -106,7 +106,7 @@ Conversion | |||
Mixed Conversion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the added doc/example.feather file?
@@ -106,7 +106,7 @@ Conversion | |||
Mixed Conversion | |||
|
|||
.. ipython:: python | |||
:okwarning: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than this can you change to a code-block (and just show what it was)
@nadebu sorry, it have been working the last days on the documentation, and this has already been fixed in the meantime. |
Hopefully you can find another issue to work on! (there are some labeled with good-first-issue) |
Also, specifically for #24173 (flake8 in the docs), there are still files left to do, so very welcome to open PRs for those. |
Sorry I missed all this conversation. My mail was being diverted and still familiarising myself with github's messaging. |
convert_objects
doesn't exist anymore, and the example in the release notes when it was added is failing and generating a warning in the doc build:Open during the London sprint.
git diff upstream/master -u -- "*.py" | flake8 --diff