Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fixed warning about convert_objects in doc build #26679

Closed
wants to merge 2 commits into from
Closed

DOC: Fixed warning about convert_objects in doc build #26679

wants to merge 2 commits into from

Conversation

nadebu
Copy link

@nadebu nadebu commented Jun 5, 2019

convert_objects doesn't exist anymore, and the example in the release notes when it was added is failing and generating a warning in the doc build:

Exception in /home/travis/build/pandas-dev/pandas/doc/source/whatsnew/v0.11.0.rst at block ending on line None
Specify :okexcept: as an option in the ipython:: block to suppress this message
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-20-d11827bcdf31> in <module>
----> 1 s.convert_objects(convert_dates='coerce')
~/build/pandas-dev/pandas/pandas/core/generic.py in __getattr__(self, name)
   5095             if self._info_axis._can_hold_identifiers_and_holds_name(name):
   5096                 return self[name]
-> 5097             return object.__getattribute__(self, name)
   5098 
   5099     def __setattr__(self, name, value):
AttributeError: 'Series' object has no attribute 'convert_objects'

Open during the London sprint.

@WillAyd
Copy link
Member

WillAyd commented Jun 5, 2019

Thanks for the PR! What warning were you getting? Any easy way to detect others?

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #26679 into master will increase coverage by 48.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #26679       +/-   ##
===========================================
+ Coverage   41.84%    90.4%   +48.56%     
===========================================
  Files         174      174               
  Lines       50663    50663               
===========================================
+ Hits        21201    45803    +24602     
+ Misses      29462     4860    -24602
Flag Coverage Δ
#multiple 90.4% <ø> (?)
#single ?
Impacted Files Coverage Δ
pandas/io/feather_format.py 21.05% <0%> (-68.43%) ⬇️
pandas/core/computation/pytables.py 62.5% <0%> (-27.44%) ⬇️
pandas/io/pytables.py 63.82% <0%> (-25.51%) ⬇️
pandas/io/clipboard/clipboards.py 31.88% <0%> (-2.9%) ⬇️
pandas/core/panel.py 17.61% <0%> (+1.68%) ⬆️
pandas/util/_test_decorators.py 93.22% <0%> (+5.08%) ⬆️
pandas/io/gbq.py 78.94% <0%> (+5.26%) ⬆️
pandas/_config/localization.py 86% <0%> (+6%) ⬆️
pandas/core/config_init.py 96.85% <0%> (+10.23%) ⬆️
pandas/compat/numpy/__init__.py 93.1% <0%> (+13.79%) ⬆️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7ad5f...27bb4de. Read the comment docs.

@datapythonista datapythonista changed the title Fixed warning in doc build DOC: Fixed warning about convert_objects in doc build Jun 6, 2019
@datapythonista
Copy link
Member

I think all the CI failures are unrelated, not sure what's broken there.

But looks like the warning is still in the docs. @nadebu can you see if you find what's wrong?

@WillAyd added more info to the description.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadebu I see that one file (doc/esample.feather was added by mistake). Can you please remove it?

Also, I think your change is probably fixing one of the errors, but a similar error is happening in the example immediately after in the PR. Can you apply the same change there please?

Thanks!

@@ -106,7 +106,7 @@ Conversion
Mixed Conversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the added doc/example.feather file?

@@ -106,7 +106,7 @@ Conversion
Mixed Conversion

.. ipython:: python
:okwarning:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than this can you change to a code-block (and just show what it was)

@jorisvandenbossche
Copy link
Member

@nadebu sorry, it have been working the last days on the documentation, and this has already been fixed in the meantime.

@jorisvandenbossche
Copy link
Member

Hopefully you can find another issue to work on! (there are some labeled with good-first-issue)

@jorisvandenbossche
Copy link
Member

Also, specifically for #24173 (flake8 in the docs), there are still files left to do, so very welcome to open PRs for those.

@nadebu nadebu deleted the documentation branch July 31, 2019 11:36
@nadebu
Copy link
Author

nadebu commented Jul 31, 2019

Sorry I missed all this conversation. My mail was being diverted and still familiarising myself with github's messaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants