-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR #25262 on branch 0.24.x (REF/TST: resample/test_base.py) #25718
Backport PR #25262 on branch 0.24.x (REF/TST: resample/test_base.py) #25718
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.24.x #25718 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 166 166
Lines 52430 52430
=======================================
Hits 48443 48443
Misses 3987 3987
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 0.24.x #25718 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 166 166
Lines 52430 52430
=======================================
Hits 48443 48443
Misses 3987 3987
Continue to review full report at Codecov.
|
@TomAugspurger why does this need to be backported? For the collection problems? |
Yeah. But if we decide to keep 0.24.x pinned at the older pytest, then this
is unnecessary.
…On Wed, Mar 13, 2019 at 4:56 PM Joris Van den Bossche < ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> why does this need to
be backported? For the collection problems?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25718 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIm0-DcCQDYIpLly65es496DsW02Hks5vWXQWgaJpZM4bwLLl>
.
|
@TomAugspurger : if this does solve the collection problem, we can close #25197. |
is this mergable or should close? |
let's see if this works |
Backport PR #25262: REF/TST: resample/test_base.py