Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix DataFrame.quantile docstring and doctests #23936

Merged
merged 3 commits into from
Dec 9, 2018

Conversation

Moisan
Copy link
Contributor

@Moisan Moisan commented Nov 27, 2018

Based on #22459. Fix the docstring for DataFrame.quantile. I also updated ci/code_checks.sh.

@pep8speaks
Copy link

Hello @Moisan! Thanks for submitting the PR.

@Moisan
Copy link
Contributor Author

Moisan commented Nov 27, 2018

Crap forgot to double check the open pull requests before working on this. Closing in favor of #22906.

@Moisan Moisan closed this Nov 27, 2018
@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #23936 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23936   +/-   ##
=======================================
  Coverage    92.2%    92.2%           
=======================================
  Files         162      162           
  Lines       51700    51700           
=======================================
  Hits        47669    47669           
  Misses       4031     4031
Flag Coverage Δ
#multiple 90.6% <ø> (ø) ⬆️
#single 43.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 96.91% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b9eea...2c972ba. Read the comment docs.

@datapythonista
Copy link
Member

@Moisan, #22906 is stale. Reopening this. If you don't mind taking a look at the discussions there, and finish the changes here, that would be great.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Moisan

the CI is currently broken, you'll have to merge maste when #24160 is fixed, so we can see everything is green.

@datapythonista
Copy link
Member

@Moisan can you merge master and push again. CI is fixed now.

@jreback jreback added this to the 0.24.0 milestone Dec 9, 2018
@jreback jreback merged commit 07cc3be into pandas-dev:master Dec 9, 2018
@jreback
Copy link
Contributor

jreback commented Dec 9, 2018

thanks @Moisan

@Moisan Moisan deleted the doctest_quantile branch December 9, 2018 18:49
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Fix the docstring of quantile in pandas/core/frame.py
4 participants