Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fixed the doctsring for _set_axis_name (GH 22895) #22969
DOC: Fixed the doctsring for _set_axis_name (GH 22895) #22969
Changes from 8 commits
a5fd1c3
5dbbbd1
bc865d4
457c58e
e469e4e
7fb8a52
067fa8d
71f3909
a7eb3d8
96a5dd1
22ef507
b030a6b
6d76d44
adc2694
9d944e8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is longer than 79 characters, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, the concept
id
refers toname
andlegs
, which does not make sense.It could make more sense to have the name as the index, and then may be a column
num_legs
and a columnnum_arms
and call the axislimbs
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem correct. Altering the labels would be changing the names of the columns, not the name of the axis itself.
And small thing, but alter doesn't necessarily need to be correct. If the axis doesn't have a name, it's setting it, but not altering.
Set
would be better I think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before, label is the names of each individual column, not the name of the axis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove
Panel
here. While it's correct, Panel it's already deprecated and will disappear in couple of months, so not worth having it.