Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only implement the actual string replacement in C.
escape
,escape_silent
, andsoft_str
are always pure Python. This greatly simplifies the C code, as it no longer needs to do type checks,__html__
check, or string conversion. No longer requires a circular import betweenMarkup
andescape
. The tests also become simpler, not requiring fixtures for each function. Moving all that to Python only slows down the benchmark by about 20 nanoseconds, which I find acceptable compared to the simpler code.@carsonburr did this when working on a Rust implementation, as it reduced the amount of non-Rust work done in the Rust code.