Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.11.x] Restrict MarkupSafe < 2.1 #1606

Closed
wants to merge 1 commit into from

Conversation

3nprob
Copy link

@3nprob 3nprob commented Mar 1, 2022

@3nprob 3nprob changed the base branch from main to 2.11.x March 1, 2022 12:44
@3nprob 3nprob changed the title Restrict MarkupSafe < 2.1 [2.11.x] Restrict MarkupSafe < 2.1 Mar 1, 2022
@3nprob
Copy link
Author

3nprob commented Mar 1, 2022

CI seems to assume master as base - this should be mergable without conflicts

@ThiefMaster
Copy link
Member

It's an old and unsupported version... we do not plan to make a release adding upper bounds; people would have to update their pin anyway, so they can simply add the pin on markupsafe instead..

@ThiefMaster ThiefMaster closed this Mar 1, 2022
@3nprob
Copy link
Author

3nprob commented Mar 1, 2022

Those who did not add an explicit pin (very much like jinja itself) have had things not breaking without intervention. Those are now failing. Publishing this change will make it work againa without depending projects adding explicit pins.

@ThiefMaster
Copy link
Member

People who did not pin Jinja would have gotten updates for both Jinja and Markupsafe -> no problem. So the only people are affected are these where only some of the deps are pinned...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants