4594 - fix unnecessary-constructor parameters for super call

[tanmoyopenroot]

PR checklist

• Addresses an existing issue: fixes unnecessary-constructor parameters for super call #4594
• enhancement
• Includes tests
• Documentation update

Overview of change:

Add check-super-calls option to unnecessary-constructor

{
  "rules": {
    "unnecessary-constructor": [
        true,
        { "check-super-calls": true }
    ]
  }
}

Is there anything you'd like reviewers to focus on?

Not sure if the option name check-super-calls is correct.

CHANGELOG.md entry:

[new-rule-option] check-super-calls option for unnecessary-constructor rule

[JoshuaKGoldberg]

A good start! 🎊
Left some comments on requested structural changes and missing test changes.

[JoshuaKGoldberg]

Looks like you have some lint failures you'll need to clean up too:

This type is not allowed in the 'if' condition because it could be undefined. Allowed types are boolean or boolean-or-undefined. (strict-boolean-expressions)
  87 | 
  88 | const isEmptyOrContainsOnlySuper = (node: ts.ConstructorDeclaration, options: Options): boolean => {
> 89 |     if (node.body) {
     |        ^
  90 |         const { unnecessarySuperCall } = options;
  91 | 
  92 |         if (!containsStatements(node.body.statements)) {

[tanmoyopenroot]

Looks like you have some lint failures you'll need to clean up too:

This type is not allowed in the 'if' condition because it could be undefined. Allowed types are boolean or boolean-or-undefined. (strict-boolean-expressions)
  87 | 
  88 | const isEmptyOrContainsOnlySuper = (node: ts.ConstructorDeclaration, options: Options): boolean => {
> 89 |     if (node.body) {
     |        ^
  90 |         const { unnecessarySuperCall } = options;
  91 | 
  92 |         if (!containsStatements(node.body.statements)) {

Done

[tanmoyopenroot]

A good start!
Left some comments on requested structural changes and missing test changes.

Done

[tanmoyopenroot]

@JoshuaKGoldberg @adidahiya ???

[adidahiya]

testNext failure is unreleated. I'd like to release this and improve it in future PRs if necessary