-
Notifications
You must be signed in to change notification settings - Fork 887
[new-rule-option] Introduce new typedef rule option (variable-declaration-ignore-function) #4769
[new-rule-option] Introduce new typedef rule option (variable-declaration-ignore-function) #4769
Conversation
Ignores typedef requirement for vars for arrow and non arrow functions. Fixes: palantir#2654
Thanks for your interest in palantir/tslint, @michaelw85! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
@JoshuaKGoldberg Could you review this PR or do you know anyone who would be able to? |
Hi yes, sorry for the delay! I will soon 🙂. For context, both adidahiya and I are maintaining TSLint in roughly part time amounts. There's also a lot of ongoing work for migrating to ESLint. So this might take a few days more. |
@JoshuaKGoldberg Thanks for the reply. Don't worry there is no rush (for me) although I would definitely be happy to have this feature. I wasn't sure if anyone noticed the PR so I thought I would tag you since you categorized the linked feature request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source code looks good to me! Just waiting on test changes.
test/rules/typedef/variable-declaration-ignore-function/test.ts.lint
Outdated
Show resolved
Hide resolved
test/rules/typedef/variable-declaration-ignore-function/test.ts.lint
Outdated
Show resolved
Hide resolved
@JoshuaKGoldberg PR is updated! Thanks for reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR @michaelw85!
testNext failures are unrelated; will file a separate issue. |
PR checklist
Overview of change:
Add new option for
typedef
rule.Ignores typedef requirement for vars for arrow and non arrow functions.
CHANGELOG.md entry:
[new-rule-option]
typedef
new option:variable-declaration-ignore-function