This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
[quotemark] Exclude some cases from backtick rule #4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes quotemark backtick ignore use strict declarations, enum members, lookup types, and strings containing octal escape sequences.
I had copy pasted and forgotten to change it. This changes that comment.
JoshuaKGoldberg
suggested changes
May 5, 2019
This commit makes it so that if a string has a literal backslash instead of an actual octal escape sequence, it is not flagged.
JoshuaKGoldberg
approved these changes
May 7, 2019
Merged
This was referenced Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes quotemark backtick ignore use strict declarations, enum members, lookup types, and strings containing octal escape sequences.
PR checklist
Overview of change:
See description. Just ignore the cases mentioned in the bug.
Is there anything you'd like reviewers to focus on?
Make sure I captured all the variations of the said cases in the tests.
CHANGELOG.md entry:
[bugfix] Quotemark backtrack now ignores enum members, use strict declarations, lookup types, and strings containing octal escape sequences.