This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Allow const assertions in no-object-literal-type-assertion #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not normal type assertions and asserting that literal objects are immutable is a normal usage pattern.
|
Thanks for your interest in palantir/tslint, @asmundg! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
JoshuaKGoldberg
suggested changes
Apr 25, 2019
There was a problem hiding this comment.
Hey @asmundg, thanks for sending this PR! Before reviewing rule changes we'll need to see tests that exercise the changed behavior.
|
@JoshuaKGoldberg this relies on a new utility function added in typescript 3.4. Is it reasonable to bump tslint's typescript dev dependency? |
JoshuaKGoldberg
suggested changes
Apr 25, 2019
|
@JoshuaKGoldberg thanks for the input, I've addressed your change requests. |
Merged
This was referenced Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not normal type assertions and asserting that literal objects
are immutable is a normal usage pattern.
PR checklist
Overview of change:
Allow const assertions in no-object-literal-type-assertion. These are not equivalent to normal type assertions, and using them on literal objects is expected behavior.
Is there anything you'd like reviewers to focus on?
CHANGELOG.md entry:
[enhancement] Allow const assertions in no-object-literal-type-assertion