Avoid computing expensive debug info for all checkState() calls

[ash211]

Before this PR

level.representation(State.startingState()) is always calculated, regardless of if the checkState() check fails. This is expensive to compute, so we should avoid doing it unless necessary.

After this PR

==COMMIT_MSG==
Avoid computing expensive debug info for all checkState() calls
==COMMIT_MSG==

Possible downsides?

None known

[changelog-app]

Generate changelog in changelog/@unreleased

What do the change types mean?

• feature: A new feature of the service.
• improvement: An incremental improvement in the functionality or operation of the service.
• fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
• break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
  and external consumers of the service's API (e.g. customer-written software or integrations).
• deprecation: Advertises the intention to remove service functionality without any change to the
  operation of the service itself.
• manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
  performing database surgery, ...) at the time of upgrade for it to succeed.
• migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

• ❗The break and manual task changelog types will result in a major release!
• 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
• ✨ All others will result in a minor version release.

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Avoid computing expensive debug info for all checkState() calls

Check the box to generate changelog(s)

• Generate changelog entry

[fawind]

Thanks!

[svc-autorelease]

Released 2.41.0