This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
refactor: refactor bad smell UnnecessaryToStringCall #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UnnecessaryToStringCall The toString() method is not needed in cases the underlying method handles the conversion. Also calling toString() on a String is redundant. Removing them simplifies the code.
|
Thanks for your interest in palantir/gradle-graal, @MartinWitt! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repairing Code Style Issues
UnnecessaryToStringCall
The
toString()method is not needed in cases the underlying method handles the conversion. Also calling toString() on a String is redundant. Removing them simplifies the code.Repairing Code Style Issues
Removing this
toStringcall removes noise because a developer has less code to understand.After this PR
==COMMIT_MSG==
Remove unnecessary toString call in BaseGraalCompilerTask
==COMMIT_MSG==
Possible downsides?
A developer could not understand that string concatenation calls the
toStringfor objects. I hope this is never the case, but this is the only downside. There is no other unneededtoStringcall in your project according to Qodana/IntelliJ