Refaster rule to convert Stream.of() -> Stream.empty() #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Nov 20, 2019
| @BeforeTemplate | ||
| Stream<T> streamNoParams() { | ||
| return Stream.of(); | ||
| } |
There was a problem hiding this comment.
I wonder if we have anything matching:
Collections.emptySet().stream()
Collections.emptyList().stream()
ImmutableList.of().stream()
ImmutableSet.of().stream()They might be too silly
There was a problem hiding this comment.
That's pretty crazy
There was a problem hiding this comment.
Ya, I doubt we have them for real, let's ship this as is :-]
added 2 commits
November 20, 2019 13:18
ferozco
force-pushed
the
fo/stream-empty
branch
from
e6e4b83 to
35df809
Compare
|
👍 |
This was referenced Nov 20, 2019
This was referenced Nov 20, 2019
This was referenced Nov 29, 2019
This was referenced Dec 16, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
Add Refaster rule to convert Stream.of() -> Stream.empty()
==COMMIT_MSG==
Possible downsides?