replace refaster executor submit->execute rule with an error-prone rule #938
Assignees
Labels
Comments
carterkozak
added a commit
that referenced
this issue
Oct 6, 2019
Previously refaster runs would eventually attempt to fix this bug. Now it blocks compilation pre-merge to ensure bugs cannot be introduced.
carterkozak
added a commit
that referenced
this issue
Oct 6, 2019
Previously refaster runs would eventually attempt to fix this bug. Now it blocks compilation pre-merge to ensure bugs cannot be introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
The refaster rule uncovered a few places where we were not logging failures, one of which hid a component that has been completely broken for months.
We should enforce this pre-merge instead of post-fixing with refaster
What did you want to happen?
New error level error prone rule to disallow ExecutorService.submit where the returned future is ignored in favor ExecutorService.execute.
For context, exceptions thrown from tasks supplied to ExecutorService.submit are not logged to the uncaught thread handler because it's assumed that the result will be read from the future. If the returned future is ignored,
executeis strictly better.The text was updated successfully, but these errors were encountered: