Try palantir-java-format #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdanfox
commented
Oct 16, 2019
| @@ -366,26 +348,21 @@ private boolean isByteBuffer(Type type) { | |||
| Type type = enriched.conjureDef().getType(); | |||
|
|
|||
| if (type.accept(TypeVisitor.IS_LIST)) { | |||
| return ImmutableList.of( | |||
| createCollectionSetter("addAll", enriched), | |||
| createItemSetter(enriched, type.accept(TypeVisitor.LIST).getItemType())); | |||
There was a problem hiding this comment.
@dansanduleac I think the number of parens in createItemSetter(enriched, type.accept(TypeVisitor.LIST).getItemType()) makes it a bit subtle to read when it's re-flowed in the new 'dense' style. Thoughts on having a heuristic that would value having opening and closing pairs of parens on the same line?
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
|
Closing out as we should use the official excavator one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a way to use the shiny new palantir-java-format here: palantir/gradle-baseline#936. Just dogfooding
It seems like the formatter is occasionally still fighting checkstyle :/