Disable spinner when running in CI #356
Conversation
todor-a
force-pushed
the
expose-no-spinner-env-var
branch
from
11c6e19 to
9b41fe4
Compare
todor-a
force-pushed
the
expose-no-spinner-env-var
branch
from
9b41fe4 to
3a7d544
Compare
todor-a
changed the title
|
@tdranv If we are talking about CI considerations, how about using the ci-info package? It seems preferable for users to be able to use it without knowing that the option exists. |
|
Hey, thanks for the prompt response. Do I understand correctly - you are suggesting disabling the spinner in general, if the command is running in a CI? |
|
Yes, I could not think of a case where a spinner would be effective in CI, so I thought it would be acceptable to disable the spinner in CI. Any cases to consider? |
|
Sounds reasonable. We should definitely add it to the documentation tho. |
|
I've made the requested changes. Let me know what you think when you get a chance, @kamiazya. Not sure where to add the disclaimer in the readme tho. 🤔 |
todor-a
changed the title
|
Hey, @kamiazya. Do you plan to release a new version soon? Thank you! :) |
Added support for disabling the spinner via an env var to make the output more CI-friendly.
For that, I updated commander to version 8.2.0, which added support for option values via env vars.