-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Is it intended that the dependencies of the root index.ts are not rendered? #258
Comments
johnnaegle
added a commit
to johnnaegle/madge
that referenced
this issue
Aug 9, 2022
Adds a test for pahen#258. Demonstrates that aggregated ES6 modules in typescript are not correctly processed. If we have an aggregated module that is in typescript: export { named } from './a-named.ts' Then made does not process the file
johnnaegle
added a commit
to johnnaegle/madge
that referenced
this issue
Aug 9, 2022
Adds a test for pahen#258. Demonstrates that aggregated ES6 modules in typescript are not correctly processed. If we have an aggregated module that is in typescript: export { named } from './a-named.ts' Then madge does not process the file
I think this may be fixed by a typescript upgrade in the project. I added a failing test in my fork for a similar case: When the aggregation is this: import { nombre } from "./c-named";
export * as default from "./a-default";
export { named } from "./b-named"; That fails with this error:
I believe this was fixed in Typescript 4.1, see here: microsoft/TypeScript#39803 |
Thanks for the suggestion. Now typescript is added as an optional peer dependency in #350 so this problem should be solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are other files that use wildcard exports, like
comp/index.ts
:The dependency between
comp/index.ts
andcomp/types.ts
is rendered correctly.So why it does not happen for the root
index.ts
? 🤔The text was updated successfully, but these errors were encountered: