Remove error message for PasswordRequiredException on SSH certificate #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PasswordRequiredException was displaying even an a certificate was loaded and de-encrypted in the SSH Agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PasswordRequiredExceptionwas displaying even if a certificate was correctly loaded and de-encrypted in the SSH Agent,Scenario: If you are using an ssh config file to configure hosts along with the ssh-agent, you should not need to explicitly pass a password for your certificate.
Fix
I removed the catch as I expect
paramiko.SSHExceptionshould gracefully handle any agent misconfiguration and paramiko's logging should make the issue clear.The alternative would be to lower the log level for this message but I would expect this to be noisy for anyone in the above scenario.