Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change - Support SpringBoot 3 & Java 17 #1663

Closed

Conversation

ludorival
Copy link

Hello,

Here is a PR to support Spring Boot 3 on Pact JVM. Since SpringBoot 3 is compiling with JDK 17, I had to pass to Java 17 in the project as well.

I have been able to test from another project and it is working with Spring Boot 3 and this local version provider:junit5spring:5.0.0.

This PR should fix #1660

Feel free to review and provide your suggestions.

Thanks,
Ludo

ludorival and others added 4 commits February 3, 2023 06:19
- Bump mockito and classgraph versions
- fix some compilation errors
# Conflicts:
#	buildSrc/src/main/groovy/au.com.dius.pact.kotlin-common-conventions.gradle
@rholshausen
Copy link
Contributor

Thanks for the PR, the change looks simple enough. I might rather add a new spring6 module that requires JDK 17 instead of making all the modules require that version.

@ludorival
Copy link
Author

Good catch @rholshausen, I can set jdk 7 for spring modules only ?

@rholshausen
Copy link
Contributor

The changes look quite simple (just some imports that are different). I am thinking of adding it to a new spring6 module, leaving the existing ones as is. Also, I don't think it has to be compiled with JDK 17, just run with it.

I will set this all up and move your changes there, I just need a little bit of time to setup a Springboot project to test it works ok.

@rholshausen
Copy link
Contributor

Ok, I have taken your changes and put them in a new spring6 module on the v4.5.x branch. I've tested it with a demo Springboot3 project, and it works ok. Commit bffd26a

@ludorival
Copy link
Author

Awesome @rholshausen ! Can I close this PR then ?

@rholshausen
Copy link
Contributor

Yes, closing this as 4.5.0-beta1 has been released with the new spring6 lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants