Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of Kotlin Result to work around build failures #1606

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

holly-cummins
Copy link
Contributor

On a clean checkout,

./gradlew clean build

fails quite quickly with errors like the following:

> Task :core:support:compileKotlin FAILED
e: /Users/holly/Code/pact/pact-jvm/core/support/src/main/kotlin/au/com/dius/pact/core/support/KotlinLanguageSupport.kt: (4, 38): Unresolved reference: Err
e: /Users/holly/Code/pact/pact-jvm/core/support/src/main/kotlin/au/com/dius/pact/core/support/KotlinLanguageSupport.kt: (5, 38): Unresolved reference: Ok
e: /Users/holly/Code/pact/pact-jvm/core/support/src/main/kotlin/au/com/dius/pact/core/support/KotlinLanguageSupport.kt: (6, 38): Unresolved reference: Result
e: /Users/holly/Code/pact/pact-jvm/core/support/src/main/kotlin/au/com/dius/pact/core/support/KotlinLanguageSupport.kt: (7, 38): Unresolved reference: UnwrapException
e: /Users/holly/Code/pact/pact-jvm/core/support/src/main/kotlin/au/com/dius/pact/core/support/KotlinLanguageSupport.kt: (37, 49): One type argument expected for class Result<out T>
e: /Users/holly/Code/pact/pact-jvm/core/support/src/main/kotlin/au/com/dius/pact/core/support/KotlinLanguageSupport.kt: (40, 25): One type argument expected for class Result<out T>
e: /Users/holly/Code/pact/pact-jvm/core/support/src/main/kotlin/au/com/dius/pact/core/support/KotlinLanguageSupport.kt: (40, 49): One type argument expected for class Result<out T>

I don't totally understand the mechanism for why, but bumping the version of michael-bull kotlin-result to the latest version fixes the issues. Being on the latest version may have other advantages.

@rholshausen rholshausen merged commit 03a8b3d into pact-foundation:master Sep 19, 2022
@holly-cummins
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants