Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PactBrokerClient): Send includePendingStatus=false when enablePending is set to false #1455

Merged
merged 3 commits into from
Sep 30, 2021
Merged

fix(PactBrokerClient): Send includePendingStatus=false when enablePending is set to false #1455

merged 3 commits into from
Sep 30, 2021

Conversation

TimothyJones
Copy link
Contributor

No description provided.

@uglyog
Copy link
Member

uglyog commented Sep 30, 2021

A test for that would be nice

@uglyog
Copy link
Member

uglyog commented Sep 30, 2021

Needs a test here: https://github.com/pact-foundation/pact-jvm/blob/master/core/pactbroker/src/test/groovy/au/com/dius/pact/core/pactbroker/PactBrokerClientSpec.groovy#L463

@TimothyJones
Copy link
Contributor Author

No problem. I'll add one in a moment.

@uglyog uglyog merged commit d014fb0 into master Sep 30, 2021
uglyog pushed a commit that referenced this pull request Oct 4, 2021
fix: broken spec after merging #1455
d86e79d
@uglyog uglyog deleted the TimothyJones-patch-1 branch March 22, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uglyog uglyog uglyog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimothyJones @uglyog