Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry condition for the pactbroker unknown response #1405 #1406

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

bawoodruff
Copy link
Contributor

No description provided.

@bawoodruff bawoodruff changed the title Fix the retry condition for the pactbroker unknown response #1405 fix: retry condition for the pactbroker unknown response #1405 Jul 21, 2021
@uglyog uglyog merged commit 1979dcb into pact-foundation:master Jul 21, 2021
@uglyog
Copy link
Member

uglyog commented Jul 21, 2021

Damn, that is a perfect example of what happens when you have a gap in your tests!

@uglyog
Copy link
Member

uglyog commented Jul 21, 2021

Actually, there was a test, but it mocked things out to match the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants