fix: Don't publish incomplete verification results #1166 #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’m not familiar with that area of the code to comment on the implementation, but it would be good to see some tests added, at least to reproduce/cover the fix. |
I can add the most basic test to ensure that respective methods are called. I just thought it would be better to also add a test on an integration test level. |
tinexw
force-pushed
the
junit5-filtered-pacts-fix
branch
from
a069194 to
f5d01e5
Compare
tinexw
force-pushed
the
junit5-filtered-pacts-fix
branch
from
f5d01e5 to
0727ff4
Compare
|
I added the simple test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1166
What is the best way to test this? I would like to add tests similar to the JUnit 4 ones. But I don't know how.