fix: fix a problem where the provider version trim property is ignored #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-ivaldi
force-pushed
the
provider-verifier-ignore-version-trim-property
branch
from
b3d4382 to
7997b32
Compare
|
Given the last few instances, @e-ivaldi and I would like to test this locally before merging, but we can't because |
e-ivaldi
force-pushed
the
provider-verifier-ignore-version-trim-property
branch
6 times, most recently
from
991624b to
0351d40
Compare
e-ivaldi
commented
Jul 2, 2020
provider/src/main/kotlin/au/com/dius/pact/provider/ProviderVersion.kt
Outdated
Show resolved
Hide resolved
e-ivaldi
force-pushed
the
provider-verifier-ignore-version-trim-property
branch
from
0351d40 to
fdb9f99
Compare
anto-ac
changed the title
uglyog
approved these changes
Jul 3, 2020
|
Tested with our services and it works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.