chore: improve logging when falling back to DateUtils.parseDate #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-ivaldi
approved these changes
Jul 2, 2020
uglyog
reviewed
Jul 3, 2020
| """Unable to parse ${valueOf(actual)} with $pattern using java.time.format.DateTimeFormatter. | ||
| Attempting to parse using org.apache.commons.lang3.time.DateUtils | ||
| to guarantee backwards compatibility with versions < 4.1.1. | ||
| """Failed to parse ${valueOf(actual)} with '$pattern' using java.time.format.DateTimeFormatter. |
There was a problem hiding this comment.
You can pass the exception to the logger method as well
logger.warn(e) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.