Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Keep existing path on baseUrl #1139

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Fix: Keep existing path on baseUrl #1139

merged 1 commit into from
Jun 19, 2020
+11 −1

Conversation

jgelon
Copy link
Contributor

@jgelon jgelon commented Jun 18, 2020

Keep path on baseUrl when combining baseUrl and url instead of throwing it away.
Solves issue #1130

@jgelon jgelon changed the title Keep existing path on baseUrl Fix: Keep existing path on baseUrl Jun 18, 2020
@uglyog
Copy link
Member

uglyog commented Jun 19, 2020

Thanks for the PR!

@uglyog uglyog merged commit 9f21d62 into pact-foundation:master Jun 19, 2020
@jgelon
Copy link
Contributor Author

jgelon commented Jun 19, 2020

@uglyog I see this has been merged. However it was not part of the release 4.1.3....

@uglyog
Copy link
Member

uglyog commented Jun 27, 2020

I've just released 4.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgelon @uglyog