fix: content-type super-type resolution for application/octet-stream … #1137
Conversation
| @@ -48,7 +48,7 @@ class ContentType(val contentType: MediaType?) { | |||
|
|
|||
| fun isBinaryType(): Boolean { | |||
| return if (contentType != null) { | |||
| val superType = registry.getSupertype(contentType) | |||
| val superType = registry.getSupertype(contentType) ?: MediaType.OCTET_STREAM | |||
There was a problem hiding this comment.
/** * Returns the supertype of the given type. If the media type database * has an explicit inheritance rule for the type, then that is used. * Next, if the given type has any parameters, then the respective base * type (parameter-less) is returned. Otherwise built-in heuristics like * text/... -> text/plain and .../...+xml -> application/xml are used. * Finally application/octet-stream is returned for all types for which no other * supertype is known, and the return value for application/octet-stream * is <code>null</code>. * * @since Apache Tika 0.8 * @param type media type * @return supertype, or <code>null</code> for application/octet-stream */ public MediaType getSupertype(MediaType type) {
|
LGTM 👍 |
…is now correct