fix: backward compatible support for Z UTC designator in timestamps #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although it feels like a bad thing to do, it looks like it might be ok. It looks like ISO 8601 Time zone designation is a superset of the RFC 822 one. But maybe we should output a warning that the substitution has been made? |
|
Good point on the warning. I’ve just realised that my change wouldn’t take into account formats with quotes though, and I think the parsing would fail in that case. |
|
Ah, yeah, that's a problem. I'm thinking we can add a JVM system property that turns on the behaviour. That way it is opt in. |
|
Or... I was thinking... a regex that substitutes only Z that are not enclosed in quotes |
uglyog
approved these changes
Jun 16, 2020
aplsup
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@uglyog what do you think about this? Perhaps a bit hacky, but at the same time there might be other organisations in a similar situation to ours.