fix: correct display name for junit5 verification provider #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uglyog The displayName was only showing the consumerName. I'm not sure if this change will be correct under all circumstances. I've tested it locally for our case of tagged, non-pending pacts coming form the broker. My use of kotlin might be dodgy here... let me know if you think that the implementation makes sense and if it could be re-written more elegantly. I haven't found any tests for the displayName. Should we add some? |
uglyog
requested changes
Jun 15, 2020
...er/junit5/src/main/kotlin/au/com/dius/pact/provider/junit5/PactJUnit5VerificationProvider.kt
Show resolved
Hide resolved
anto-ac
force-pushed
the
fix-displayname-for-junit5-verification-provider
branch
from
5468189 to
cee72ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.