fix: @PactBroker not reading Spring properties with JUnit 5 #1023

[arhohuttunen]

Fixes an issue in PactVerificationInvocationContextProvider.resolvePactSources() where calling PactBrokerLoader.description() ignores the value resolver that is being set after the call.

The method calling order breaks the PactVerificationSpringProvider that is trying to override the getValueResolver() method to be able to load broker properties from a Spring Boot application.yml file.

[arhohuttunen]

I was also thinking about some kind of test for it, but could not easily figure out a clean way to do it.

What do you think about adding spring-boot-starter-test and spring-boot-starter-web as test dependencies into the pact-jvm-provider-junit5-spring module?

Then you could have a kind of an integration test with this kind of approach:

src/test/resources/application.yml:

pactbroker:
  host: localhost
  port: ${local.server.port}

PactVerificationSpringProviderTest.kt:

@ExtendWith(SpringExtension::class)
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
@Provider("Animal Profile Service")
@PactBroker
@IgnoreNoPactsToVerify
internal class PactVerificationSpringProviderTest {
    @TestTemplate
    @ExtendWith(PactVerificationSpringProvider::class)
    fun pactVerificationTestTemplate(context: PactVerificationContext?) {
        context?.verifyInteraction()
    }
}

[uglyog]

Thanks for the PR!

You're test method is clever, and I can confirm that it works. I have added those changes to the module.

[uglyog]

4.0.8 released with this change